Clearly toy guns. Gun-like, but nobody with the slightest understanding of guns would think they were real. I have no problem with kids having toy guns. I do have a problem with kids in public having realistic replica guns. Bright orange isn't enough.
I think the answer is that other than in organized events realistic replicas should be subject to the same restrictions on actions that real guns are.
Toy guns back then: https://i.imgur.com/2DQnhNC.jpeg
Never saw those, but from the picture that looks too small to be a real gun.
How about: https://www.youtube.com/watch?v=dbYlrSRhsZk