I think offsetting the em dash with spaces is contrary to almost every style guide.

I think this is a localisation issue; in the UK, it's much more common to see space-surrounded em dashes.

Chicago does it one way and AP does it the other.

I definitely prefer it un-spaced, though, personally.