> Draft pull requests will not count towards your limit.
Disappointing, it seems that those also need limits too, although the limit could be higher.
I could easily see the limit for PRs be at 1 for untrusted contributors, and drafts at 3-5.
> Draft pull requests will not count towards your limit.
Disappointing, it seems that those also need limits too, although the limit could be higher.
I could easily see the limit for PRs be at 1 for untrusted contributors, and drafts at 3-5.
It would be cool if they took the approach Flickr does to groups. You can submit your photo to groups (a kind of curated collage, usually with a certain theme or aesthetic). But the admin can have certain rules, like the photo can only be submitted to a certain number of groups in total, or a limit on how many photos you submit. Some groups are interesting with rules like you can submit only a single picture.
I'd just limit the total. Otherwise people will use it to game the system.
Or using it correctly... depends on what your system is, or more accurately, your policy on reviewing or quickly merging PRs with "Draft" status.
As long as it's taken as an indicator for WIP, it works. It just doesn't work when acting illiterate of this distinction; and I have often have had PRs switched to "ready", reviewed + merged in a couple of hours.
But when the change list grows, and the PR ages, while still being intentionally maintained, the Draft signal is strong and helpful IMO. Switching an old Draft PR to "ready" after reviving it with changes seems like a useful signal to me.
I think you're missing the point. Limiting the number of PRs, but not counting draft PRs, just means the SPAM PRs will all be drafts. This solves (almost) nothing.
> Or using it correctly...
Note that people using AI to make spam pull requests are not using the system correctly.