"I thought the goal was to generate tax revenue from the taxes, which wouldn't happen to the extent they end up in the hands of NYC residents."

You're right, I'm saying I think it is a good tax for reasons secondary to revenue. We all know NYC is going to squander the money, at least they might make housing slightly cheaper for the average New Yorker in the process.