It's not just a valid comparison; for some of us, it's the only comparison that matters. Upgradability and repairability are really nice features, but the machine still needs to otherwise be an upgrade over the one it's replacing.
If the Framework Pro holds up in reviews and works as well with Linux as claimed, it'll probably replace my M2 Air as a daily driver. If they add Dvorak as an option so I don't have to rearrange the keys myself, that will make the choice a slam dunk.
IMHO you should just stay with a Mac. The Framework Pro is the antithesis of a Mac, you can literally take your old framework's mainboard and network card and put them into the new chassis. Everything is replaceable. As long as they continue with that trend, it'll always be thicker and heavier than a Mac, and will always make compromises.
The video says that directly. They want to compete with MacBook, but people coming to Framework from Mac are attracted to the idea of owning their own computer and being able to customise it.