>The desire to come and immigrate to the US has greatly diminished

Do you have any data to back up that claim?

E.g. the number of diversity lottery applicants (one of the easiest proxies to judge how many people express their interest in moving to the US) went up from 12 million in 2011 to almost 20 million last year.

This thread is largely about college educated folks who represent a small minority of diversity lottery applicants. As to why the DV lottery has grown, I suspect it has a lot to do with it just having become more visible and known, growing hand in hand with increased access to internet and ability to apply.

Sure, if we are talking about the top end we can check the O-visas, the "extraordinary ability in the sciences, arts, education, business, or athletics" ones, both the applications and the issuance of those went up even more than the DV applications:

https://en.wikipedia.org/wiki/O_visa#Number_of_visas_issued_...