Do many people do bash on osx or zsh on Linux, and would this make much of a difference?

I don't know about "use" — luckily, there's no opt-out telemetry — but enough of "enthusiast distribution" users who have also opted in (very biased sample) have explicitly installed zsh (not necessarily run it)

https://pkgstats.archlinux.de/compare/packages#packages=bash...

OTOH, it's only 4-7% on Debian (also opt-in):

https://qa.debian.org/popcon.php?package=zsh

Why does this type of statistic require an opt-in solution? Can't the Arch mirrors just tally requests for each package without identifying information like IP adddress?

Maybe they can’t ask for info on every mirror.

I use zsh at work and bash at home. I am such an unsophisticated user that I haven't noticed a real difference! Other than I can install ohmyzsh on zsh.

I repeat the different variations of the same command so often that I get a large quality of life improvement by making that easier- that's why I take the trouble to install zsh.

Regrettably due to the licensing stupidity there's actually two bash on macOS: /bin/bash and $HOMEBREW_PREFIX/bin/bash they do differ (as is expected by a two major version spread)

I'm firmly in the never-zsh camp, but I'd guess so long as one doesn't do something silly like use #!/bin/zsh in shared scripts you can continue to use whatever interactive shell you like

I had a college who was hard core into fish but had to be completely self sufficient because he was the only user in the office. I presume it's the same as being on Linux in a Windows shop or being on Windows in a macOS shop: no one has the day to day experience to have the answers handy

Homebrew bash is my default shell on macOS.