new | ask | show | jobs
charlie-83 4 days ago  [ - ]

Cool, couple of comments. The website it a bit broken on mobile (at least for me) since text goes off the screen. Second, it would be good to have some sample pages or at least a page of contents so people can see the level of detail the book is aimed at. I know I could just get the book for free and then pay later but that kind of a faff and I feel bad choosing $0 for these kinds of things.

petr25102018 4 days ago  [ - ]

Thanks for the feedback. I was trying to make it work on mobile but maybe I didn't test it well in the end.

As for a sample, I will go and try to make something now. Thanks.

Edit: Example pages here: https://drive.google.com/file/d/1PkUcLv83Ib6nKYF88n3OBqeeVff...

PeterWhittaker 4 days ago  [ - ]

One nit: ^D only exits if the cursor is at the beginning of a line. Enter <space>^D and the session remains.

Otherwise, looks good! Use of "env" and proper quoting are strong signals!

petr25102018 4 days ago  [ - ]

Thanks for the clarification. I will see if I can sneak in a note about this in the next update :)

danadam 3 days ago  [ - ]

page 112

> if [[ "${1-}" =~ ^-*h(elp)?$ ]]; then

> ... is an option that starts with one or multiple - characters ...

"one or multiple" is + not *. The regex above will also match "h" and "help" without - character(s).

pipes 4 days ago  [ - ]

I agree with all this. I'm on Firefox android, pixel, lose part of the screen too.

I'd love to read a table of contents. I don't want to rip you off with zero dollars!

Anyway, sounds like a great book. Congratulations on completing and "shipping"!

petr25102018 4 days ago  [ - ]

> I agree with all this. I'm on Firefox android, pixel, lose part of the screen too.

Ah okay, I really wasn't aware. Thanks for reporting.

jaredhallen 4 days ago  [ - ]

I am also seeing text off the screen using Brave on Android.

petr25102018 4 days ago  [ - ]

You are right. It is wrong, will need to look into this.

curtgrimes 4 days ago  [ - ]

These two tweaks should improve it (by preventing the largest text and book graphic from overflowing the viewport horizontally on some smaller screen sizes):

  diff --git a/index.html b/index.html
  index a0f978c..040e50e 100644
  --- a/index.html
  +++ b/index.html
  @@ -21,3 +21,3 @@
         h1 {
  -        font-size: 3.8em;
  +        font-size: clamp(2.2em, 7vw, 3.8em);
           margin-bottom: 0;
  @@ -60,2 +60,3 @@
         .hero-img {
  +        max-width: 100%;
           transform: rotate(2deg);
Also, I really like what I see in your book so far and I am already learning things on the first few pages. Thanks!
petr25102018 3 days ago  [ - ]

Oh that's great. Thanks!